Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Wheels #14

Open
naveen521kk opened this issue Oct 22, 2020 · 2 comments
Open

Build Wheels #14

naveen521kk opened this issue Oct 22, 2020 · 2 comments

Comments

@naveen521kk
Copy link

I would like to have wheels distributed in PyPi which may possibly avoid installation issues. Something like including the binaries of Pango can be done so that users no need to download it manually(Windows and Mac).

Something like https://github.com/getsentry/milksnake can be used for it and also auditwheels would surely help here.

@leifgehrmann
Copy link
Owner

So the installation issues related to "ModuleNotFoundError" will be unrelated to whether the pango/pangocairo binary is installed. Hopefully those installation issues are resolved by #17.

But in any case, I can understand why including a binary can be useful in some situations.

On the other hand, I'm not quite sure this is a good idea, since some users might expect pangocffi/pangocairocffi to use the binary that's installed on their machine (e.g. I have pango installed on my Mac via homebrew)

Looking at how cairocffi does things, they currently don't appear to bundle the binary in their wheels, although I see you've made a PR to do just that for Windows! 😄

I'll need to research a bit more about best practices.

@naveen521kk
Copy link
Author

It would be just enough to create one for windows because finding those library is way worse there.
If you could look at the issue I created in weasyprint repo ( Kozea/WeasyPrint#1241), you could see a more detailed explanation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants