You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A new major release of Golden Layout is available. Unfortunately, this has many changes that break GCV. The breaking changes I am currently aware of are:
The new version is implemented in TypeScript so Golden Layout should now be imported with import { GoldenLayout } from 'golden-layout' rather than as a script in the angular.json file.
Items no longer have a getItemsById method, which GCV heavily uses. This can be resolved by iterating an item's contentItems array and filtering those items by id and (regardless of id) recursively searching their contentItems, although it may be requesting that this feature be added back.
Nested stacks are no longer supported; only items of type component can be a direct descendant of a stack. So GCV either needs to drop its nested stacks (e.g. dot plots) or we need to request that this functionality be added back.
Golden Layout now copies item configurations when creating an item from a configuration. A deep copy is used but the properties copied are limited to an object's own properties, meaning GCV's prototype chains are not preserved by this copy (e.g. dot plots can't be retrieved because this requires attributes up the prototype chain). This could be resolved by making our own copies first that flatten the prototype chain, but having support for the prototype chain copy build into Golden Layout would be ideal.
The text was updated successfully, but these errors were encountered:
A new major release of Golden Layout is available. Unfortunately, this has many changes that break GCV. The breaking changes I am currently aware of are:
import { GoldenLayout } from 'golden-layout'
rather than as a script in theangular.json
file.getItemsById
method, which GCV heavily uses. This can be resolved by iterating an item'scontentItems
array and filtering those items byid
and (regardless ofid
) recursively searching theircontentItems
, although it may be requesting that this feature be added back.component
can be a direct descendant of a stack. So GCV either needs to drop its nested stacks (e.g. dot plots) or we need to request that this functionality be added back.The text was updated successfully, but these errors were encountered: