Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check intensity at the reference target before trying to align zlp #9489

Open
leginonbot opened this issue Mar 19, 2024 · 4 comments
Open

check intensity at the reference target before trying to align zlp #9489

leginonbot opened this issue Mar 19, 2024 · 4 comments

Comments

@leginonbot
Copy link
Collaborator


Author Name: Anchi Cheng (@anchi2c)
Original Redmine Issue: 9489, https://emg.nysbc.org/redmine/issues/9489
Original Date: 2020-10-29
Original Assignee: Anchi Cheng


AutoZLP can fail in different ways if the reference area is not clear of obstruction. Sometimes, GMS function won't even return. Doing a test on the intensity can reduce crashing.

@leginonbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Anchi Cheng (@anchi2c)
Original Date: 2020-10-29T23:57:45Z


The threshold is determined by images already saved with the preset. It also has a minimal threshold of 5.0.

@leginonbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Anchi Cheng (@anchi2c)
Original Date: 2020-11-03T22:29:49Z


This does not work well because the preset comes often from Focus node preset sequence and therefore either fc or fa. There are usually no image saved for it. Bright image values tend to come from very different imaging parameter. Also badly aligned ZLP image can be very low intensity, too.

Left at minimal threshold for now. It does prevent calling ZLP alignment when camera is in error state which would have stalled the call, too.

@leginonbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Anchi Cheng (@anchi2c)
Original Date: 2020-11-10T23:57:03Z


Changed to use the first test image to determine the threshold. This should work better.

@leginonbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Anchi Cheng (@anchi2c)
Original Date: 2020-11-16T22:11:39Z


Diabled in 3.5 because its results is still wrong in certain condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant