Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise A/E routines #56

Open
theHenks opened this issue May 22, 2024 · 1 comment · Fixed by #65 or #77 · May be fixed by #87
Open

Revise A/E routines #56

theHenks opened this issue May 22, 2024 · 1 comment · Fixed by #65 or #77 · May be fixed by #87
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@theHenks
Copy link
Collaborator

Follow CM's advice and include a drift time correction in the A/E routine.
Here, in general, two options are possible:

  • Do a combined fit for the Compton bands and optimize for minimal sigma function.
  • Combine all "calibrated" A/E distributions of all Compton bands and do one global max{peak_height/fwhm} optimization as in the CTC algorithm for the energy

In general, the routines have often times stability problems, so I think there is no way out of the combined fits. @fhagemann Can you have a look into this?
If not, I would take care of it and then see how far I will get here. Also @LisaSchlueter might have a look here. There are definitely already code snippets available for doing such combined fits.

@theHenks theHenks added bug Something isn't working enhancement New feature or request labels May 22, 2024
@legend-exp legend-exp deleted a comment from gipert Aug 7, 2024
@theHenks
Copy link
Collaborator Author

theHenks commented Aug 7, 2024

ToDos:

  • @fhagemann opens PR with changes for combined A/E compton band fits with help from @verenaaur
    (Add combined A/E fit routine #65)
    New routines will have _combined in function names
  • Compare the goodness of old to new routine by looking at the distribution of residuals for a wide variety of detectors
  • Check if certain Compton bands need to be excluded from fits based on poor perfomance (e.g. bad residuals, p-values, combination etc.)
  • Check that the distribution of A/E classifier is centered around 0 and has a standard deviation of 1
  • Implement drift time correction routine

@theHenks theHenks linked a pull request Aug 16, 2024 that will close this issue
@theHenks theHenks linked a pull request Oct 9, 2024 that will close this issue
@fhagemann fhagemann linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants