Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uplot.setSeries(null, {show: true}) doesn't work #680

Closed
zefirka opened this issue Apr 2, 2022 · 3 comments · Fixed by gravity-ui/yagr#60
Closed

uplot.setSeries(null, {show: true}) doesn't work #680

zefirka opened this issue Apr 2, 2022 · 3 comments · Fixed by gravity-ui/yagr#60

Comments

@zefirka
Copy link
Contributor

zefirka commented Apr 2, 2022

Hi @leeoniya

According to this typings next code should work

uplot.setSeries(null, {show: true})

as well as uplot.setSeries(null, {focus: true}). But if we see at the implementation, we can find that it will not work (cuz of s will be undefined).

So is it a bug, or the wrong typing? If it's a bug, I can try to fix it.

@leeoniya
Copy link
Owner

leeoniya commented Apr 3, 2022

should be fixed now. try it out.

@zefirka
Copy link
Contributor Author

zefirka commented Apr 5, 2022

Yep, it works. Can you publish plz?

@leeoniya
Copy link
Owner

leeoniya commented Apr 5, 2022

want to track down and fix this one first: #683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants