Support arguments to options with leading - #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks great! I'll take a closer look and hope to merge later this week. |
|
@leejarvis When you release these changes? It is very necessary. Thanks! |
|
Sorry about the wait, I've just released v4.4.0 |
kenhys
added a commit
to kenhys/mruby-slop
that referenced
this pull request
Apr 24, 2019
See leejarvis/slop#192 Basically, latest slop 4.6.2 should be supported, but it takes times to fix for mruby. so as a first step, only leading "-" support is backported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows negative values as arguments to numeric options and strings
starting with - for any other type.
Fixes #170
Fixes #179