-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caption file list has inappropriate hover background #4836
Comments
Hello! @bjester I would like to take on this issue. I have worked through the first one assigned and submitted the PR. Thank you :) |
HI @Arunima22! Sure, I have assigned you the issue. Thank you for your interest! |
@akolson thank you! Any guidance as to which code file I can start with would be of great help! |
I think you could start by checking out our developer documentation and getting your server up and running locally (if you haven't already done so). Once set up, you can follow the "Steps to Reproduce" and then use the Vue devtools to do some inspection. This will help you find the component and eventually the file to make the changes to. Be sure to let me know incase you have any questions in the process. :) |
https://github.com/user-attachments/assets/aaa4ce61-b433-41b7-8a3e-06e4ce91f6dd How I recreated the issue? -Logged in to [email protected] I would also like to propose something here for better designing, related to this issue. Would that be alright? |
@Arunima22 Is your video of the latest |
Hello @bjester after some more inspection, I can see that you are right. Whenever I log in using https://unstable.studio.learningequality.org/en/accounts/#/ and sign in, I see the weird grey color over there. I am using google chrome, yes. It might be possible that I am doing something different trying to reproduce the issue locally. Here are the things I did:
I am curious as to why this might not replicate on the devserver. Let me know. |
@Arunima22 I'm able to reproduce it locally. Perhaps it's best to find another issue if you're unable to replicate it. I see you commented on one involving context menus. I will assign you that instead. Thanks for looking at this. |
@bjester let me give it one more try and if it doesn't work, maybe you can unassign me then? Thank you! |
@bjester I am interested to solve this issue , can you please assign this issue to me ?? |
Thank you for your interest @shruti862. I've assigned you |
@bjester Thank you for assigning the issue. I am raised PR , please look into it whenever you get time. |
Hi @shruti862, I wanted to mention that Learning Equality will be closed from December 23 to January 5. |
Observed behavior
When you start adding a caption file to a video resource, the file item has a very strong grey background when hovered.
Expected behavior
The background should be a lot more subtle, similar to when hovering over uploaded files in the same edit modal
Steps to Reproduce
The text was updated successfully, but these errors were encountered: