Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper text for the "?" in the license/source modal #4679

Closed
marcellamaki opened this issue Aug 26, 2024 · 7 comments · Fixed by #4716
Closed

Add helper text for the "?" in the license/source modal #4679

marcellamaki opened this issue Aug 26, 2024 · 7 comments · Fixed by #4716
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@marcellamaki
Copy link
Member

Noticed in the Aug 20 bug bash

Current behavior

The "?" seems like it should be a clickable button, and in the full screen edit modal, it is interactive.
image

Not sure if this was not specced, or if it just is still to be implemented, but I think this is meant to be interactive.

@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression TAG: user strings labels Aug 26, 2024
@radinamatic
Copy link
Member

radinamatic commented Aug 28, 2024

In the full Edit details window this ? button opens the About licenses modal, but I would recommend against opening one modal on top of the other.

about-licenses

@LianaHarris360
Copy link
Member

@radinamatic Is there an alternative, preferred way for displaying that information? Should the "About licenses" be presented as a full page?

@radinamatic
Copy link
Member

Been thinking about that since yesterday... 🤔

Full page is certainly a preferred option, but I'm not sure if/how that refactor and regression testing plays with our current release plans. cc @marcellamaki and @jtamiace for thoughts.

@marcellamaki
Copy link
Member Author

i really don't know if this is a good idea, but what if (for the short term) we got rid of the ? and added, below, an "About licenses ⌄" small link style button, show this all inline in the modal, and then a "show less" at the bottom to close it. Not great. but perhaps better than a modal in modal, and probably much more reasonable than a more significant refactor right now.

@marcellamaki
Copy link
Member Author

Removing the user string labels for string freeze/translation tracking purposes, as the strings are already present in a shared translation file.

@LianaHarris360
Copy link
Member

Would it be beneficial to implement a toggle link style button with a downward and upward arrow to control the display of the About Licenses section? For example:

About Licenses Not Displayed About Licenses Displayed
AboutDown AboutUp

@radinamatic
Copy link
Member

Yes, this looks great, @LianaHarris360, thank you! 💯 👏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants