-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce KTextTruncator component for text truncation #4591
Comments
hey @MisRob can you assign this to me? |
Hey @lokesh-sagi125! Thanks for your interest in contributing to this issue 👐. I just assigned it to you. Please let us know if you have any questions (:. |
Hi @lokesh-sagi125, are you working on this or planning to? Just to know if we should keep the assignment or not. |
Hi @MisRob can you assign this issue to me. |
hey @MisRob sorry for the inactivity , i just raised the PR's for the issues in KDS and Kolibri, i am willing to work on this issue now |
Hi @sr376 and @lokesh-sagi125. I will assign this back to @lokesh-sagi125. @sr376 Welcome and thank you for volunteering! There are other contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:
You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories. |
hey @MisRob how can i test the changes i made to the frontend in studio , can you link the documentation page if there is one, |
Hi @lokesh-sagi125! Here you can find more information about how to test these KDS updates in Studio: https://github.com/learningequality/kolibri-design-system/blob/develop/dev_docs/03_how_to_update_library.md#2-preview-updates-in-a-product. Let me know any question :) |
hey @AlexVelezLl i have been getting this error since i ran git reset--hard |
Hey @lokesh-sagi125! Can you confirm that you are indeed in the Studio folder? I see a |
Could you try running |
hey @AlexVelezLl i was able to fix the issue i was facing , i was using |
Hi @MisRob, I am currently giving my end-semester tests, so is it fine if I raise a PR by the end of this month? Please reassign if this issue needs to be resolved before then. Thank you:) |
Hi @lokesh-sagi125, first wishing you all the best for the tests :)! Thanks a lot for letting us know. It's absolutely fine you returned to this issue later. It's not time sensitive, so happy to have it wait for you as it sounds you're interested. |
Thank you @MisRob. I will get back to the issue as soon as my tests end, same with the issue in Kolibri :) |
Hi @lokesh-sagi125, I wanted to mention that Learning Equality will be closed from December 23 to January 5 |
yes @MisRob i will try to close all my open issues before the 23rd. |
No need to @lokesh-sagi125 :) I'm posting the message so you know we won't be responding until later in January. |
@lokesh-sagi125 I doubt we'd be able to review this week anyway, some of us are already slowly transitioning to time off, me included :) Be well and hope to see you around next year! |
yes, @MisRob, I wouldn't want to interrupt your time off . Happy holidays🎄🎊 :) |
🌱 Are you new to the codebase? Welcome and please see the contributing guidelines.
Expected behavior
Whenever relevant, Studio should use
KTextTruncator
component from the Kolibri Design System (KDS) to achieve text truncation.One example is text truncation in the ClipboardChip.vue but there will likely be more places.
Current Behavior
Studio currently uses its own implementation for text truncation.
Impact
This is part of migrating Studio to KDS.
KTextTruncator
provides a robust and well-tested solution for text truncation and will eliminate the need to re-implement truncation.Trade-Offs
Not aware of any.
Guidance
ellipsis
.KTextTruncator
, refer to its documentation. If working with the design system for the first time, study how otherK
components are used in Studio.KTextTruncator
. If that's the case, please mention reasons for not using it in your pull request.Acceptance Criteria
KTextTruncator
wherever relevant.KTextTruncator
has been introduced have been visually reviewed and do not have any regressions.KTextTruncator
is better not to be used has been provided in the pull request.The text was updated successfully, but these errors were encountered: