Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise matadata - Incorrect completion value for Practice quiz #4215

Closed
pcenov opened this issue Jul 11, 2023 · 6 comments · Fixed by #4260
Closed

Exercise matadata - Incorrect completion value for Practice quiz #4215

pcenov opened this issue Jul 11, 2023 · 6 comments · Fixed by #4260
Assignees
Labels
P1 - important Priority: High impact on UX

Comments

@pcenov
Copy link
Member

pcenov commented Jul 11, 2023

Observed behavior

This is a follow-up issue for #4180.
If there's an Exercise with Completion set to 'Practice quiz' then in the details the Completion is incorrectly set to 'Goal: 100% correct'

Expected behavior

To be further specified.

Steps to reproduce the issue

  1. Sign in to Studio and open a channel
  2. Create an exercise and set the Completion to Practice.
  3. View the resource metadata window

Additional information

2023-07-11_15-23-40

Usage Details

@akolson
Copy link
Member

akolson commented Aug 21, 2023

Hi @marcellamaki @bjester, I am seeking clarity on the expected behavior as this was not specified at the time of opening the issue.

@marcellamaki
Copy link
Member

hi @akolson - I think we should just hide the "completion" option here. Alternatively, we could say "practice quiz". What do you think @bjester @rtibbles?

@bjester
Copy link
Member

bjester commented Aug 21, 2023

I think showing the same thing that the edit modal says for completion makes sense. So the edit modal option is 'Practice quiz' and I think that's most appropriate for clarity. I assume we have that string globally available, but if not, we've changed plans and are planning on doing a full-release from unstable up to production, so please avoid moving strings around!

@rtibbles
Copy link
Member

I agree, just showing 'Practice Quiz' seems the correct thing to display here.

@akolson
Copy link
Member

akolson commented Aug 21, 2023

Luckily, Practice Quiz exists already, so no need to move around strings 🎉

@radinamatic
Copy link
Member

I was about to ask for a change, but luckily the string already has the correct capitalization Practice quiz 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants