Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read properties of undefined (reading 'parent') #4209

Closed
sentry-io bot opened this issue Jul 7, 2023 · 2 comments
Closed

TypeError: Cannot read properties of undefined (reading 'parent') #4209

sentry-io bot opened this issue Jul 7, 2023 · 2 comments
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 7, 2023

I suspect oldObj isn't available. Maybe its value doesn't get relayed to other clients, in a multiple editor scenario?


Sentry Issue: STUDIO-GE5

TypeError: Cannot read properties of undefined (reading 'parent')
  at resourceCounts.applyMove (./shared/data/applyRemoteChanges.js:298:23)
  at ChangeDispatcher.apply (./shared/data/applyRemoteChanges.js:74:29)
  at resourceCounts.apply (./shared/data/applyRemoteChanges.js:204:18)
  at changeStream.doWrite (./shared/data/applyRemoteChanges.js:374:24)
@rtibbles
Copy link
Member

rtibbles commented Jul 7, 2023

Yeah, oldObj is always being stripped before being sent to the backend: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/frontend/shared/data/serverSync.js#L25

We do store additional fields in a JSONField though, so I think it should be OK to add where needed.

@bjester bjester self-assigned this Jul 14, 2023
@bjester bjester added the P0 - critical Priority: Release blocker or regression label Jul 14, 2023
@bjester bjester added this to the Studio: upcoming patches milestone Jul 17, 2023
@bjester bjester removed their assignment Aug 28, 2023
@rtibbles
Copy link
Member

Fixed in #4278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

3 participants