Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct issues with malformed channel trees having descendant nodes of non-folder nodes #4155

Closed
bjester opened this issue Jun 20, 2023 · 3 comments
Closed

Correct issues with malformed channel trees having descendant nodes of non-folder nodes #4155

bjester opened this issue Jun 20, 2023 · 3 comments
Assignees
@bjester @vkWeb
Labels
P1 - important Priority: High impact on UX
Milestone
Studio: prioritiz...

Comments

@bjester
Copy link
Member

bjester commented Jun 20, 2023 •
edited
Loading

Observed behavior

While migrating public channels to the new public API data model, we discovered one channel that has an html5 content node acting as topic/folder, having additional descendant nodes underneath.

Problematic channels:

  • b431ba9f16a3588b89700f3eb8281af0

Expected behavior

We prevent the ricecooker API from attaching children or descendants to nodes that are not topics/folders

User-facing consequences

Unknown

Errors and logs

#4136
@bjester bjester added this to the Studio: upcoming patches milestone Jun 20, 2023
@bjester bjester self-assigned this Jun 20, 2023
@bjester bjester mentioned this issue Jun 20, 2023
Merged
24 tasks
@bjester bjester mentioned this issue Jul 5, 2023
Merged
@bjester bjester removed their assignment Jul 17, 2023
@bjester bjester added P1 - important Priority: High impact on UX and removed TODO: needs decisions labels Jul 17, 2023
@bjester
Copy link
Member Author

bjester commented Jul 17, 2023

Main change should be to add the defensiveness in the ricecooker APIs.

@vkWeb vkWeb self-assigned this Jul 26, 2023
@vkWeb
Copy link
Member

vkWeb commented Jul 26, 2023

Will work on this.

@bjester bjester self-assigned this Sep 1, 2023
@bjester
Copy link
Member Author

bjester commented Sep 1, 2023

Resolved in 63693d3

@bjester bjester closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjester bjester

@vkWeb vkWeb

Labels
P1 - important Priority: High impact on UX
Projects
None yet
Milestone
Studio: prioritization of releases/pa...
Development

No branches or pull requests
2 participants
@bjester @vkWeb