Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel (soft) deletion doesn't track the history of the change #4148

Closed
bjester opened this issue Jun 15, 2023 · 1 comment · Fixed by #4615
Closed

Channel (soft) deletion doesn't track the history of the change #4148

bjester opened this issue Jun 15, 2023 · 1 comment · Fixed by #4615

Comments

@bjester
Copy link
Contributor

bjester commented Jun 15, 2023

Observed behavior

A user deleting their channel, or an admin deleting a channel from the Admin page, does not record the deletion in ChannelHistory. This is because both bypass where that is handled.

Expected behavior

We should track these deletions in the history.

User-facing consequences

We can't audit who deleted a channel

Steps to reproduce the issue

  1. Create a channel
  2. Delete the channel
  3. Query the database for the channel history
  4. Observe no deletion action
  5. Query the database for deletion or update related change events
  6. Observe no corresponding change events
@bjester
Copy link
Contributor Author

bjester commented Jun 15, 2023

Moving the tracking to the model so it's always called should be most robust. Although, it also worth considering updating how we submit and process the deletion actions since it's currently bypassing our change event architecture, leaving questions of whether a channel deletion is propagated to other clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment