Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google Cloud KMS to latest version #3885

Closed
rtibbles opened this issue Dec 15, 2022 · 0 comments · Fixed by #4019
Closed

Update Google Cloud KMS to latest version #3885

rtibbles opened this issue Dec 15, 2022 · 0 comments · Fixed by #4019
Assignees
@ozer550
Labels
DEV: backend P0 - critical Priority: Release blocker or regression TAG: dependencies
Milestone
Studio: Q2 2023 R...

Comments

@rtibbles
Copy link
Member

Version 2.0.0 introduced breaking changes to the API, so to keep dependencies up to date, we would need to update our usage of this library.

This would involve updating usage of the library in this file: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/utils/secretmanagement.py

And ensuring the invocation is correct here: https://github.com/learningequality/studio/blob/unstable/k8s/encrypt-env-var.sh

Following the migration guide here: https://github.com/googleapis/python-kms/blob/release-v2.0.0/UPGRADING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozer550 ozer550

Labels
DEV: backend P0 - critical Priority: Release blocker or regression TAG: dependencies
Projects
None yet
Milestone
Studio: Q2 2023 Release
Development

Successfully merging a pull request may close this issue.

Migrate python-kms to 2.0.0 ozer550/studio
3 participants
@bjester @rtibbles @ozer550