Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previewer metadata - Missing 'Captions and subtitles' info for an .mp3 resource #3876

Closed
pcenov opened this issue Dec 12, 2022 · 5 comments · Fixed by #3999
Closed

Previewer metadata - Missing 'Captions and subtitles' info for an .mp3 resource #3876

pcenov opened this issue Dec 12, 2022 · 5 comments · Fixed by #3999
Assignees
Labels

Comments

@pcenov
Copy link
Member

pcenov commented Dec 12, 2022

Observed behavior

The 'Captions and subtitles' info for an .mp3 resource is not being displayed in the previewer. This is working correctly for .mp4 files.

Expected behavior

Unless otherwise specified the 'Captions and subtitles' metadata should be displayed as specified in Figma.

Steps to reproduce the issue

  1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel with an .mp3 resource with added captions and subtitles and click the resource to see the previewer.
  3. Observe the lack of 'Captions and subtitles' data

Additional information

2022-12-12_17-14-58

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Dec 12, 2022

@radinamatic

@radinamatic
Copy link
Member

In addition, the edit modal for audio files is missing the section with the option to add the accessibility metadata, that is to correctly annotate the audio resource which is accessible because it has the VTT file with captions.

a11y-audio

Technically, audio resource could have the sign language captions too, but then it would become a video, and I'm unsure if our current architecture supports that 🙂
So for the time being let's fix the missing ability to add the proper accessibility metadata for the audio files.

cc @bjester for the patch/iteration planning.

@bjester
Copy link
Member

bjester commented Dec 13, 2022

I did bring up that the 'Has captions or subtitles' accessibility option could apply to audio as well, but the product feedback I received was that the option was focused on videos given its textual description and that a 'Has transcript' option would be better suited for audio. Therefore this is working as it was intended from the product perspective.

@radinamatic
Copy link
Member

Thanks for the background info, can't say I recall that conversation 🤔

As it stands now, we do not have the Has transcript accessibility metadata category, and for the user who needs this feature, the difference between captions and transcript is trivial. Having neither is an accessibility barrier, therefore I don't see the reason NOT to have the captions option just because the transcript could be seen as slightly better.

Moreover, the feature to display available captions as an interactive transcript is of your own making, so where exactly is the problem? 🙂

Actually, we do have a (bigger) problem, as the videoJS implementation for audio files in both Studio and Kolibri does not seem to display the captions even when the VTT file is uploaded in the edit modal. Big faux pass, how did I miss that...??? 😞

@bjester
Copy link
Member

bjester commented Dec 13, 2022

Yes, I understand we don't have a Has transcript label. If it is indeed better, which it seems so, then it's best we go the route of adding the new label. It's prudent because once we migrate everything, we won't know the difference between something a user explicitly set versus something we migrated to have the label, meaning it isn't alterable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants