Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language filter dropdown in import search renders incorrectly #3666

Closed
bjester opened this issue Sep 22, 2022 · 1 comment
Closed

Language filter dropdown in import search renders incorrectly #3666

bjester opened this issue Sep 22, 2022 · 1 comment
Assignees
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression

Comments

@bjester
Copy link
Member

bjester commented Sep 22, 2022

Observed behavior

  • The language dropdown shows inline instead of an absolutely positioned dropdown
  • The parent container (<aside>) can shrink to widths less than 300px, which should be the minimum size
Dropdown container <aside> width
Screenshot from 2022-09-22 11-08-58 Screenshot from 2022-09-22 11-09-42

Expected behavior

  • The language dropdown should show as a hovering box, absolutely positioned below the field
  • The parent container should have a minimum width of 300px

User-facing consequences

  • Inconsistencies with the dropdown display between different filters
  • The lack of minimum width means that language option text could be clipped by the parent container if less than 300px

Additional information

The <aside> element is in a flex layout with percentage widths, so it instead have a minimum width and the sibling element should grow to fill the remaining space

Steps to reproduce the issue

  1. Open a channel for editing
  2. Click ADD and select 'Import from channels'
  3. Type a random string into the keyword search, to get the filters to display
  4. Click on the 'Language' filter field
  5. Observe the dropdown displays inline

Usage Details

  • OS: Ubuntu 20.04
  • Browser: Chrome
@bjester
Copy link
Member Author

bjester commented Sep 30, 2022

Closed by #3679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: regression
Projects
None yet
Development

No branches or pull requests

1 participant