Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My channels display has no discernable ordering #3559

Closed
rtibbles opened this issue Aug 19, 2022 · 9 comments · Fixed by #3592
Closed

My channels display has no discernable ordering #3559

rtibbles opened this issue Aug 19, 2022 · 9 comments · Fixed by #3592
Assignees
Labels
DEV: frontend P1 - important Priority: High impact on UX

Comments

@rtibbles
Copy link
Member

My channels list display either has no ordering or is ordering by an opaque field like id.

Instead we should order by last modified time, or alphabetically by title (if last modified time ordering would be a performance issue).

@bjester
Copy link
Member

bjester commented Aug 29, 2022

I recall us looking into this before, and that we need some frontend logic for this since we store these in IndexedDB?

@bjester bjester added P1 - important Priority: High impact on UX DEV: frontend labels Aug 29, 2022
@rtibbles
Copy link
Member Author

This sounds familiar - I just wanted to make sure the issue was tracked, but I couldn't recall what we had discussed about this previously.

@marcellamaki
Copy link
Member

I thought it was sorted by last modified time 🤔 but maybe we never implemented it?

@marcellamaki
Copy link
Member

Ah, I just remember the related issue, but apparently past Marcella didn't actually fix the problem

@bjester
Copy link
Member

bjester commented Aug 29, 2022

Oh, yeah I searched and didn't see any open issues, but I was mostly wondering for adding a frontend/backend label

@rtibbles
Copy link
Member Author

Ah, yes, these issues are almost identical.

@rtibbles
Copy link
Member Author

So, I went to look at this, and it seems that we are actually ordering by last_modified time. However, we don't display the last modified time to the user anywhere, so the ordering still looks completely arbitrary.

@rtibbles
Copy link
Member Author

Oh... and it seems like the sort by modified is just not sorting properly. Not sure why it is happening, but it is definitely not sorting them properly by the modified date.

@rtibbles
Copy link
Member Author

And it seems this is because sortBy was being used in a way that seems plausible when reading the code, but does not actually reflect the lodash documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants