Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Learning Activities" in DetailsTabView: Set default values on file upload #3373

Closed
sairina opened this issue Apr 18, 2022 · 0 comments · Fixed by #3612
Closed

"Learning Activities" in DetailsTabView: Set default values on file upload #3373

sairina opened this issue Apr 18, 2022 · 0 comments · Fixed by #3612
Assignees
Labels
P1 - important Priority: High impact on UX TAG: new feature

Comments

@sairina
Copy link
Contributor

sairina commented Apr 18, 2022

Observed behavior

According to the designs for the "Learning Activities" dropdown, there should be a default value set depending on the type of resource (audio, video, document).

PR #3370, the input for "Learning Activities" only allows the user to edit the "Learning Activities" input, but does not have a default set depending on kind.

Expected behavior

Setting the default should happen at file upload time instead.

User-facing consequences

Defaults are not currently set, and if this input is empty, an error shows up for the user.

Errors and logs

Additional information

I had originally used the getter for learning_activities in DetailsTabView to determine the default based on this.firstNode.kind. However, some issues to note that occurred were:

  • the value was set in the UI, but not set in the backend, so validation always showed an error (that the field was empty)
  • whenever the field was completely cleared, because of the default, we automatically saw the default pop pretty immediately

Because of this, we're tagging this as a follow-up issue that would finish the "Learning Activities" field (per specs) in the edit modal, and there is a connected issue for the backend to migrate data here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX TAG: new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants