Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions with resized images published under Spanish or French will break in Kolibri #3341

Closed
rtibbles opened this issue Mar 15, 2022 · 0 comments · Fixed by #3406
Closed
Assignees
Labels
bug P0 - critical Priority: Release blocker or regression

Comments

@rtibbles
Copy link
Member

Observed behavior

The templates for rendering the Perseus JSON for assessment items do not escape or jsonify the designated width or height of images, e.g.

(but also true for other question types as well).

This means that in languages that do not use . as the decimal separator, and when the width and height of an image are non-integer, the rendered value will break later JSON parsing, as JSON expects . separated numbers.

Expected behavior

Should always output valid JSON regardless of the currently active translation language.

User-facing consequences

Users publishing their channels when the interface is set to Spanish or French could suffer unpredictable breakages in Kolibri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants