Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor's offline indicator showing on sign-in page #3226

Closed
bjester opened this issue Jul 7, 2021 · 0 comments · Fixed by #3851
Closed

Editor's offline indicator showing on sign-in page #3226

bjester opened this issue Jul 7, 2021 · 0 comments · Fixed by #3851
Assignees
Labels
DEV: frontend P2 - normal Priority: Nice to have

Comments

@bjester
Copy link
Member

bjester commented Jul 7, 2021

Observed behavior

The offline indicator that shows in the channel editor is also showing on the sign-in page.

Expected behavior

I'm not sure this indicator should be visible since we recently added an offline message to the actual form.

User-facing consequences

The indicator's tooltip text shown on hover is confusing in the context of the sign-in page, as seen in the screenshot

Additional information

Screenshot from 2021-07-07 15-48-39

Steps to reproduce the issue

  1. Open Studio's sign-in page, unauthenticated
  2. Open Chrome's Dev Tools and the Network tab
  3. Change network throttling to "Offline"
  4. Observe the results in the screenshot

Usage Details

  • OS: Ubuntu 20.04
  • Browser: Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P2 - normal Priority: Nice to have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants