Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't publish a channel when the only updates are its thumbnail, title, language, or description #3101

Closed
MisRob opened this issue Apr 15, 2021 · 2 comments · Fixed by #3134
Assignees
Labels
P1 - important Priority: High impact on UX

Comments

@MisRob
Copy link
Member

MisRob commented Apr 15, 2021

Observed behavior

Assume that I have an existing channel that has already been published, which means that the "Publish" button is disabled on the channel editor page. When I update only the channel's details, that is its thumbnail, title, language, or description, the "Publish" button stays disabled, and I can't publish the updated channel.

Expected behavior

The "Publish" button is enabled after I update only the channel's thumbnail, title, language, or description, and I can publish the channel.

User-facing consequences

Users can't publish a channel if they update its details only.

They need to update its resources as a workaround to be able to publish it as described in the original report:

Reported by UN Women:

It doesn’t seem possible to update and publish Channel details alone (e.g., upload a new thumbnail, change the description or title) – it seems like you have to delete or add resources within the channel. I changed the Channel thumbnail and edited the description on my Second Chance channel, but the Publish button wasn’t activated. So I had to add a dummy PDF in order to publish those changes and then had to delete the PDF.

Additional information

Recording

Peek 2021-04-15 09-52

Notes

We track a root tree node and children nodes changes in the changed field on a node which is used to decide if there are any changes to be published. Based on that, the "Publish" button is displayed as enabled or disabled. However, it seems that there is no similar mechanism for tracking channel changes.

Steps to reproduce the issue

  1. Go to the channel editor page for a channel that you can edit
  2. Publish the channel if it hasn't been published already and see the "Publish" button disabled
  3. Click the "Edit channel details" pencil button in the top bar
  4. Update only the channel's thumbnail/title/language/description without making any updates to its children resources
  5. See the "Publish" button still disabled

Usage Details

  • OS: Ubuntu
  • Browser: Chrome
@rtibbles
Copy link
Member

When updating Channel details, also set channel.main_tree.changed = True, and sync that change to the frontend.

@micahscopes micahscopes removed their assignment Jun 11, 2021
@lauradanforth
Copy link

FYI this issue was flagged again by UN Women Mexico on June 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants