Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failure of copy tasks #2850

Closed
metodimilevqa opened this issue Jan 21, 2021 · 7 comments
Closed

Handle failure of copy tasks #2850

metodimilevqa opened this issue Jan 21, 2021 · 7 comments
Assignees
Labels
P1 - important Priority: High impact on UX

Comments

@metodimilevqa
Copy link

metodimilevqa commented Jan 21, 2021

Summary

Sometimes a red loader/spinner is seen when the user tries to import from channels - as it is unclear why the loader is red but not green we need to handle this better on the FE and make it more clear for the user what exactly is happening (task failed).

Category

BUG

Usage Details

Experienced at: https://studio.learningequality.org/

  • Windows 10
  • Browser: Chrome (latest)
  • Channel: ziviv-fodon

Screenshots

redLoaderStudio

Real-life consequences (anything community should be aware of, for instance how it affects end users)

Unclear for the user that the task has failed.

Expected behaviour

  • "Copy failed" text
  • A "Retry" action
  • An icon to remove the failed task
  • An error icon in the side panel (more specs in image)

spinner

This will require some backend work to allow 'retry' of a failed copy task. The simplest way around this would be to delete the previously failed copy and then do the copy again.

In order to ensure the proper order of operations for this, this is best done after some clean up of the sync behaviour.

@rtibbles rtibbles added this to the Post Release Stabilization milestone Jan 21, 2021
@rtibbles rtibbles added the P1 - important Priority: High impact on UX label Jan 26, 2021
@rtibbles
Copy link
Member

We need to alert to the user that a task has failed, and also do a delete to roll back any copying that has happened so far.

@jtamiace jtamiace self-assigned this Feb 16, 2021
@jtamiace
Copy link
Member

jtamiace commented Mar 9, 2021

Looking for some review on this recommendation, which is to replace the red spinner with the red error icon along with:

  • "Copy failed" text
  • A "Retry" action
  • An icon to remove the failed task
  • An error icon in the side panel (more specs in image)

spinner

@rtibbles
Copy link
Member

This seems like the appropriate change - the main thing from a technical perspective will be to either allow resuming the current copying job, or deleting the first attempted copy, and then retrying (the latter strategy is less efficient but seems more sure fire).

@rtibbles rtibbles added TODO: needs decisions design: todo Scoped and ready for design work to begin and removed needs design TODO: needs decisions labels Mar 12, 2021
@rtibbles rtibbles removed the design: todo Scoped and ready for design work to begin label Mar 29, 2021
@rtibbles rtibbles changed the title A red loader/spinner is seen when the user tries to import from channels - unclear why, need to handle this better on the FE Handle failure of copy tasks and allow cancel or retry Apr 6, 2021
@MisRob MisRob removed their assignment Oct 14, 2021
@bjester bjester removed this from the 2022 Q2: stability milestone Sep 19, 2022
@bjester bjester changed the title Handle failure of copy tasks and allow cancel or retry Handle failure of copy tasks Oct 11, 2022
@bjester bjester added this to the Studio: next major release milestone Jan 18, 2023
@vkWeb
Copy link
Member

vkWeb commented Apr 9, 2023

@bjester sir to offload some of your load for the next major release, maybe I can take this one?

@bjester
Copy link
Member

bjester commented Apr 10, 2023

@vkWeb Yes you can take this on, as I haven't done any work towards it. @AllanOXDi had mentioned interest in working with me on it. Perhaps you can followup with him on it?

@vkWeb
Copy link
Member

vkWeb commented Apr 10, 2023

@bjester Sure sir, I'll talk to Allan about this and I will start working on this after getting change event PR merged!

@bjester
Copy link
Member

bjester commented Sep 5, 2023

Resolved by @vkWeb in #4176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants