Nodes from chef runs should be properly marked as complete/incomplete

[jayoshih]

Observed behavior

The internal cheffing API does not validate all conditions in determining whether a node is complete. It currently only validates against empty titles and invalid license fields.

Expected behavior

A node should be validated against all of the same conditions that the mark_incomplete management command handles.

References

Partially handled for titles and licenses in #2999

[jonboiser]

On chef runs, actually detect if the node is valid instead of defaulting to true (this line)

Any pointers on how to do this? What would make a node invalid?

[rtibbles]

This management command contains the comprehensive list of different conditions:

https://github.com/learningequality/studio/blob/hotfixes/contentcuration/contentcuration/management/commands/mark_incomplete.py

Might be good to write a backend utility function (with tests) that encapsulates these conditions.

[jonboiser]

@rtibbles The implementation of the mark_complete is basically

For each criterion C, filter all ContentNodes that don't meet C, then update their complete field to False.

Whereas, I think what we want to do in the create_node method is check all the criteria for just a single node, based on the node_data dict passed into the function.

How do you think a utility function could be written that is usable in both spots?

[rtibbles]

Oh, I don't think we'd need to write something that worked for both - just a 'node validation' function would be sufficient for the single node case.

[bjester]

@AtKristijan This may break many existing chef scripts so we should do some auditing before merging this change. I'm not sure if it's possible, but if this does break many chefs, perhaps we can surface these new validations as warnings instead of strict validation?