Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentNode Thumbnails different from the ones uploaded #1266

Closed
ivanistheone opened this issue Mar 6, 2019 · 3 comments
Closed

ContentNode Thumbnails different from the ones uploaded #1266

ivanistheone opened this issue Mar 6, 2019 · 3 comments
Assignees
Labels

Comments

@ivanistheone
Copy link
Contributor

Summary

Content nodes exported by studio develop have square thumbnails, even though rectangular thumbs were uploaded:
screen shot 2019-03-06 at 9 34 05 am

On Kolibri:
http://pradigi-demo.learningequality.org/content/storage/6/d/6d37a5dec387529d3972d405471f5d32.png
6d37a5dec387529d3972d405471f5d32

source thumb:
http://www.prathamopenschool.org/CourseContent/coverImages/kn_geetababeeta.png
kn_geetababeeta

I checked and the file in chef's storage is wide format: 251 x 154

chef@vader:~/sushi-chef-pradigi$ file storage/9/5/9531cf9887e854a1ea9a734902665a6d.png
storage/9/5/9531cf9887e854a1ea9a734902665a6d.png: PNG image data, 251 x 154, 8-bit/color RGB, interlaced

Category

Select one: BUG

Usage Details

  • Channel: PraDigi f9da12749d995fa197f8b4c0192e7b2c
  • Topic/Content Item: all of them

Real-life consequences

Ricecooker-uploaded content will look wrong if this thumnail changes get deployed to production.

@ivanistheone
Copy link
Contributor Author

I suspect the cropping to square ratio is happening during EXPORT step, because thumbnail looks OK on the content node:
https://develop.studio.learningequality.org/channels/f9da12749d995fa197f8b4c0192e7b2c/edit/24222b6/454edad

@ivanistheone ivanistheone changed the title ContentNode Thumbnails different from the ones uploaded [develop only] ContentNode Thumbnails different from the ones uploaded Mar 6, 2019
@ivanistheone
Copy link
Contributor Author

Update it's not just on develop -- I just re-ran the chef in production:
https://studio.learningequality.org/channels/f9da12749d995fa197f8b4c0192e7b2c/edit/f9da127

after export the thumbnails get cropped to square again

@ivanistheone
Copy link
Contributor Author

I've tagged this as "high priority" because Pratham team has repeatedly asked me to "fix" the thumbnails. Hopefully easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants