Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Linking KDS commit that fixes window scrolling to top on button click… #9877

Conversation

LianaHarris360
Copy link
Member

… for testing

Summary

When clicking on KDropdownMenu button, the page scrolls to top. This draft pr includes the change in KDS that fixes this.

Screen recording showing button click behavior after fixing

AfterChange.mov

References

Reference to issue mentioned here #9833 (comment)

Reviewer guidance

  1. After starting kolibri server, navigate to device settings page
  2. Under Other Storage Locations section, click the options button and confirm that page does not scroll to top and menu options display as expected.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@LianaHarris360 LianaHarris360 changed the title Linking KDS commit that fixes window scrolling to top on button click… [DO NOT MERGE] Linking KDS commit that fixes window scrolling to top on button click… Dec 8, 2022
@LianaHarris360 LianaHarris360 marked this pull request as ready for review December 8, 2022 19:53
@pcenov
Copy link
Member

pcenov commented Dec 9, 2022

Tested and verified that now the page doesn't scroll to the top and the menu options are displayed correctly.

@radinamatic
Copy link
Member

Closing as the corresponding KDS PR has been approved.

@radinamatic radinamatic closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants