Pass the correct kwargs to the cleanupsyncs management command.

[rtibbles]

Summary

• The morango cleanupsyncs command takes push and pull kwargs to specify push and pull cleanups, but our task wrapper is currently passing is_push and is_pull
• Rectifies this by correcting the kwargs after the validation has happened
• Updates the relevant test

References

No extant issue - noticed while doing some testing on Django 3.2 upgrading, where Django now complains if you pass non-existent kwargs to a management command!

Reviewer guidance

I ran the tests, with the tweak they passed.

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b13.dev0_git.20.gf16a6fb4.pex
Windows Installer (EXE)	kolibri-0.16.0b13.dev0+git.20.gf16a6fb4-unsigned.exe
Debian Package	kolibri_0.16.0b13.dev0+git.20.gf16a6fb4-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b13.dev0+git.20.gf16a6fb4-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b13.dev0+git.20.gf16a6fb4-0.1.0-debug.apk
TAR file	kolibri-0.16.0b13.dev0+git.20.gf16a6fb4.tar.gz
WHL file	kolibri-0.16.0b13.dev0+git.20.gf16a6fb4-py2.py3-none-any.whl

[bjester]

I think it might be better to pass in the correct arguments to begin with, here https://github.com/learningequality/kolibri/blob/develop/kolibri/core/auth/kolibri_plugin.py#L54-L55

[rtibbles]

Sure - I was going for the fewest changes, but if it's fine to change the function signature, then happy to do that.

[rtibbles]

Updated!

[bjester]

Prathamesh and I made sure the test coverage properly covered this, but obv improperly asserted these. So looks good to me!