From ac1f58c94596fdcdac23ff226b1e9e716e08762f Mon Sep 17 00:00:00 2001 From: shivangrawat30 Date: Sat, 30 Sep 2023 00:28:28 +0530 Subject: [PATCH 1/2] Solved the page title Error Signed-off-by: shivangrawat30 --- .../plan/LessonSummaryPage/LessonOptionsDropdownMenu.vue | 4 +++- .../src/views/plan/LessonSummaryPage/ManageLessonModals.vue | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/LessonOptionsDropdownMenu.vue b/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/LessonOptionsDropdownMenu.vue index a28b1ce805b..72c5d609968 100644 --- a/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/LessonOptionsDropdownMenu.vue +++ b/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/LessonOptionsDropdownMenu.vue @@ -45,7 +45,9 @@ label: this.$tr('copyLessonAction'), value: 'COPY', }, - { label: this.coreString('deleteAction'), value: 'DELETE' }, + { label: this.coreString('deleteAction'), + value: 'DELETE', + }, ]; } diff --git a/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue b/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue index 0a91ddfc95b..4852dd4e989 100644 --- a/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue +++ b/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue @@ -115,8 +115,8 @@ const { id } = this.currentLesson; return LessonResource.deleteModel({ id }) .then(() => { - this.$router.replace( - this.$router.getRoute('PLAN_LESSONS_ROOT', { classId: this.classId }), + this.$router.replace( + this.$router.getRoute('PLAN_LESSONS_ROOT'), () => { this.showSnackbarNotification('lessonDeleted'); } From 1b6791e732305e149af7a658a70ecd468350cf0a Mon Sep 17 00:00:00 2001 From: shivangrawat30 Date: Sat, 30 Sep 2023 18:06:00 +0530 Subject: [PATCH 2/2] changed the parameter for PLAN_LESSONS_ROOT route Signed-off-by: shivangrawat30 --- .../src/views/plan/LessonSummaryPage/ManageLessonModals.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue b/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue index 4852dd4e989..5d72e657d49 100644 --- a/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue +++ b/kolibri/plugins/coach/assets/src/views/plan/LessonSummaryPage/ManageLessonModals.vue @@ -116,7 +116,7 @@ return LessonResource.deleteModel({ id }) .then(() => { this.$router.replace( - this.$router.getRoute('PLAN_LESSONS_ROOT'), + this.$router.getRoute('PLAN_LESSONS_ROOT', this.id ? { classId: this.classId } : {}), () => { this.showSnackbarNotification('lessonDeleted'); }