Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] temp reference to new KDS PR commit (for regression of testing KModals & KSelects) #10449

Conversation

thanksameeelian
Copy link
Contributor

DO NOT MERGE

Summary

Temp reference to KDS PR: allow KSelect to extend outside of KModal

The scenario addressed in that PR (and raised in KDS issue 324), where a KSelect is inside a KModal and displays unexpected behavior, currently only occurs in KDP. At present, there are no KSelects inside KModals in Kolibri and there have been barriers to testing in KDP, but the new behavior of the combination of those two components is documented in the KDS PR.

This Kolibri PR exists so that regression testing can occur for general KModal & KSelect behavior.

References

Reviewer guidance

  • regression testing for KModal and KSelect as there have been underlying changes

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic
Copy link
Member

Performed various workflows that involve interacting with KModal and KSelect in Firefox and Chrome on Ubuntu 20.04 with the DEB asset installed, and in Firefox, Edge and Chrome on Windows 10 with the EXE asset installed. No regressions were appreciated, both the mouse and keyboard interactions behaved as expected.

Looking forward to testing an actual KSelect inside KModal workflow!

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passed, good to go! 💯 :shipit:

@rtibbles
Copy link
Member

Closing - updates to KDS can be brought in in a dedicated PR.

@rtibbles rtibbles closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants