[DO NOT MERGE] temp reference to new KDS PR commit (for regression of testing KModals & KSelects) #10449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Summary
Temp reference to KDS PR: allow KSelect to extend outside of KModal
The scenario addressed in that PR (and raised in KDS issue 324), where a
KSelect
is inside aKModal
and displays unexpected behavior, currently only occurs in KDP. At present, there are noKSelect
s insideKModal
s in Kolibri and there have been barriers to testing in KDP, but the new behavior of the combination of those two components is documented in the KDS PR.This Kolibri PR exists so that regression testing can occur for general
KModal
&KSelect
behavior.References
Reviewer guidance
KModal
andKSelect
as there have been underlying changesPR process
Reviewer checklist
yarn
andpip
)