Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Content Browsing: Create 'My Downloads' Page #9861

Closed
9 tasks
marcellamaki opened this issue Nov 21, 2022 · 1 comment
Closed
9 tasks

Remote Content Browsing: Create 'My Downloads' Page #9861

marcellamaki opened this issue Nov 21, 2022 · 1 comment
Assignees

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Nov 21, 2022

Overview

This issue is a front-end issue to add an "My Downloads" page that will display all content that has been downloaded to the device's Kolibri.

Specifications

Figma

Please see complete figma spec for full specs.

Screenshot 2023-01-31 at 9 10 32 AM

Screenshot 2023-01-31 at 9 10 48 AM

Screenshot 2023-01-31 at 9 11 46 AM

Screenshot 2023-01-31 at 9 15 19 AM

Screenshot 2023-01-31 at 9 17 30 AM

Screenshot 2023-01-31 at 9 17 41 AM

Acceptance Criteria

  • The "My downloads" page has been added to Kolibri, and is visible in the main navigation menu
  • A user can filter and sort the results
  • The downloads page is paginated in increments of 25 results
  • A user can select one, multiple, or all results on the page to remove them from their downloads
  • On "remove", the user is sees a confirmation modal
  • Selection of results is persisted across pages
  • The "Total size of downloads" can just be a sum of the file size data (i.e. we do not have to build around edge cases such as duplicate resources, rounding, etc.)
  • The "Free disk space" should be limited by the device settings. See Device Settings Milestone for context.
  • When a user wants to download a resource, use the (to be created) API endpoint that allows you to query if the resource is needed by anyone/anything other than this user. This is to account for a "remove download" scenario for 2+ user accounts on the same device, for example, where they have downloaded the same resource, and one person wants to remove it. The user should still be able to "delete" the resource from their downloads list, but the actual resource should remain on the device. The available space can update based on what the user sees.

Currently blocked

The following scenarios need design feedback before they can be implemented.

  1. Do we need the total size of "My Library"? (Probably not - skip implementing for now)
  2. What should we display to a user when they downloaded a resource and garbage collection cleaned it up.
  3. Modification to the UI and modal for the "a remove download scenario for 2+ user accounts" as detailed above

Out of scope

Updates to the content renderer display are out of scope and covered in #9856

Please note that the updates the native app navigation are temporarily blocked by the App Bar updates, and can be done in follow up as needed.

References

@rtibbles
Copy link
Member

Implemented in #10137 - any follow up will be done in #10379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants