Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Syncing Updates: Accessibility Remediations in Coach page #9849

Closed
5 tasks
marcellamaki opened this issue Nov 21, 2022 · 0 comments · Fixed by #10212
Closed
5 tasks

Automatic Syncing Updates: Accessibility Remediations in Coach page #9849

marcellamaki opened this issue Nov 21, 2022 · 0 comments · Fixed by #10212
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@marcellamaki
Copy link
Member

Overview

This issue is a frontend issue that updates the report and plan tabs in the Coach plugin with improved accessibility features. The pages should:

  • Include the new TabGroup component created in KDS
  • Have new visually hidden h2 tags that will use semantic HTML to group the information architecture of the page that is currently only grouped visually

Specifications

Figma

Please see complete figma spec for all relevant screens and details. Below is just one example:
Screen Shot 2022-11-21 at 3 21 07 PM

Acceptance Criteria

  • Reports Page has been refactored to include the new KDS TabGroup component
  • Plan Page has been refactored to include the new KDS TabGroup component
  • When viewing a lesson or quiz, the side panel has a visually-hidden h2: “General information”
  • When viewing a lesson or quiz, the main content has a visually-hidden h2: “Details”
  • THIS MUST pass accessibility QA from @radinamatic before it can get merged. Her approval is blocking.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants