Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check 0.16 onboarding strings #9626

Closed
radinamatic opened this issue Aug 16, 2022 · 8 comments
Closed

Check 0.16 onboarding strings #9626

radinamatic opened this issue Aug 16, 2022 · 8 comments
Assignees
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated

Comments

@radinamatic
Copy link
Member

Follow up issue from #9534.

Observed behavior

In the 0.16 setup wizard we changed almost all the instances of the word facility into learning facility to give better context for localization, but there may be some that were not changed in #9534. This change is applicable only to the setup wizard pages where we have no screen space concerns, while in the actionable elements like buttons in the rest of the UI the string will remain just facility.

183448291-45ddb12c-edf1-408d-8987-d8e5c7b03d7a

Figma designs

Import facility: Desktop | Mobile
Loading Facility: Desktop | Mobile Mobile 2
Select super admin: Desktop | Mobile

Errors and logs

Expected behavior

All onboarding (setup wizard) pages use learning facility instead of just facility.

User-facing consequences

Steps to reproduce

Context

  • Kolibri version: 0.16
@radinamatic radinamatic added P1 - important Priority: High impact on UX TAG: beginner friendly TAG: user strings Application text that gets translated APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Aug 16, 2022
@radinamatic radinamatic added this to the 0.16.0 milestone Aug 16, 2022
@nucleogenesis nucleogenesis added P0 - critical Priority: Release blocker or regression and removed P1 - important Priority: High impact on UX labels Aug 16, 2022
@camperjett
Copy link
Contributor

@radinamatic I would like to take up this issue

@rtibbles
Copy link
Member

rtibbles commented Aug 29, 2022

Hi @camperjett - you are welcome to take a look at this - this would be on the develop branch, confirming that we have not missed any instances of this. Please search for all instances of facility in user facing strings in the setup wizard and ensure that we have updated to learning facility.

@10kartik
Copy link

Hello @camperjett, are you working on this issue? else I'm interested to contribute for the same.

@MisRob
Copy link
Member

MisRob commented Sep 8, 2022

Hi @10kartik, thank you for your interest. As we haven't heard from @camperjett for some time, and we will need to have this ready before the next major release, if you're interested, you're welcome to tackle this issue. If you could let me know as soon as you start working, that'd be helpful so we know that it's in progress. Otherwise, we will assign this to one of the core team members in the next couple of weeks.

@10kartik
Copy link

10kartik commented Sep 9, 2022

Yeah @MisRob, I'd like to give it a try! I'll try to explore more around and fix this issue. Thanks!

@MisRob
Copy link
Member

MisRob commented Sep 9, 2022

Great, thanks

@MisRob
Copy link
Member

MisRob commented Sep 13, 2022

@10kartik We realized that this might be hard to test and preview due to some work in progress on develop and also because of design access. It's not that it would be impossible, though if you haven't started working on this yet, I'd recommend choosing another issue.

@10kartik
Copy link

10kartik commented Sep 13, 2022

Cool @MisRob, I'll search for another issue.. Thanks!

@10kartik 10kartik removed their assignment Sep 13, 2022
@marcellamaki marcellamaki self-assigned this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated
Projects
None yet
Development

No branches or pull requests

7 participants