-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check 0.16 onboarding strings #9626
Comments
@radinamatic I would like to take up this issue |
Hi @camperjett - you are welcome to take a look at this - this would be on the develop branch, confirming that we have not missed any instances of this. Please search for all instances of |
Hello @camperjett, are you working on this issue? else I'm interested to contribute for the same. |
Hi @10kartik, thank you for your interest. As we haven't heard from @camperjett for some time, and we will need to have this ready before the next major release, if you're interested, you're welcome to tackle this issue. If you could let me know as soon as you start working, that'd be helpful so we know that it's in progress. Otherwise, we will assign this to one of the core team members in the next couple of weeks. |
Yeah @MisRob, I'd like to give it a try! I'll try to explore more around and fix this issue. Thanks! |
Great, thanks |
@10kartik We realized that this might be hard to test and preview due to some work in progress on |
Cool @MisRob, I'll search for another issue.. Thanks! |
Follow up issue from #9534.
Observed behavior
In the 0.16 setup wizard we changed almost all the instances of the word
facility
intolearning facility
to give better context for localization, but there may be some that were not changed in #9534. This change is applicable only to the setup wizard pages where we have no screen space concerns, while in the actionable elements like buttons in the rest of the UI the string will remain justfacility
.Figma designs
Import facility: Desktop | Mobile
Loading Facility: Desktop | Mobile Mobile 2
Select super admin: Desktop | Mobile
Errors and logs
…
Expected behavior
All onboarding (setup wizard) pages use
learning facility
instead of justfacility
.User-facing consequences
…
Steps to reproduce
…
Context
The text was updated successfully, but these errors were encountered: