Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research benefits & LOE of moving common code to package #9589

Closed
1 of 3 tasks
nucleogenesis opened this issue Aug 4, 2022 · 1 comment
Closed
1 of 3 tasks

Research benefits & LOE of moving common code to package #9589

nucleogenesis opened this issue Aug 4, 2022 · 1 comment
Labels
P1 - important Priority: High impact on UX TAG: performance User-facing performance TODO: needs decisions Design or specifications are necessary

Comments

@nucleogenesis
Copy link
Member

nucleogenesis commented Aug 4, 2022

Observed behavior

Follow-up on this comment - overall, it may be worthwhile to consider moving some common (although not core) code out of our default front-end bundle.

The idea being that if we expose this code in a package, then when a plugin uses common code, it will be bundled with that plugin's bundle. Conversely, a plugin that does not use some common code will have it shaken out of their builds.

So - we should see a significant reduction in the size of the default frontend build which is loaded on every page along with a relatively small increase to each plugin's build size.

Thoughts on differentiating between "core" and "common"

@rtibbles said:

"What do we think we need to expose, and are prepared to support for people outside Learning Equality building frontend plugins for Kolibri?"

If you take this on and don't feel comfortable deciding on what to move and what not do, prepare and schedule a meeting with the likes of @marcellamaki @rtibbles and @nucleogenesis to walk through the core API spec and to decide on what should go where.

Acceptance Criteria

  • A new package is created in Kolibri called kolibri-common
  • The core API spec is reduced in size
  • Provide before & after outcomes for the production and dev build sizes
@rtibbles
Copy link
Member

rtibbles commented Jan 3, 2024

Closing in favour of #5488

@rtibbles rtibbles closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX TAG: performance User-facing performance TODO: needs decisions Design or specifications are necessary
Projects
None yet
Development

No branches or pull requests

3 participants