Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order paginated FacilityUser queryset #9413

Closed
marcellamaki opened this issue May 6, 2022 · 1 comment
Closed

Order paginated FacilityUser queryset #9413

marcellamaki opened this issue May 6, 2022 · 1 comment
Assignees
@rtibbles
Labels
P1 - important Priority: High impact on UX
Milestone
Planned Patch 2: ...

Comments

@marcellamaki
Copy link
Member

Observed behavior

The recent pagination PR for the FacilityUser did not also include an update to order the paginated results.

Errors and logs

/home/richard/.pex/install/kolibri-0.15.2-py2.py3-none-any.whl.b1f6d8c79573a7c7990a890cbd916d25e85a6288/kolibri-0.15.2-py2.py3-none-any.whl/kolibri/core/utils/pagination.py:37: UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list: <class 'kolibri.core.auth.models.FacilityUser'> SyncableModelQuerySet.
super(ValuesViewsetPaginator, self).init(object_list, *args, **kwargs)

Expected behavior

Users should be ordered

User-facing consequences

Confusing UI
@marcellamaki marcellamaki added the P1 - important Priority: High impact on UX label May 6, 2022
@rtibbles rtibbles assigned rtibbles and unassigned rtibbles May 10, 2022
@rtibbles rtibbles mentioned this issue May 10, 2022
Merged
9 tasks
@rtibbles
Copy link
Member

Fixed in #9422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtibbles rtibbles

Labels
P1 - important Priority: High impact on UX
Projects
None yet
Milestone
Planned Patch 2: Content and a11y
Development

No branches or pull requests
2 participants
@rtibbles @marcellamaki