Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hybrid learning cards to use just content object prop #8564

Closed
marcellamaki opened this issue Oct 29, 2021 · 1 comment · Fixed by #8638
Closed

Refactor hybrid learning cards to use just content object prop #8564

marcellamaki opened this issue Oct 29, 2021 · 1 comment · Fixed by #8638
Assignees
@marcellamaki

Comments

@marcellamaki
Copy link
Member

Pass content object in HybridLearningCardGrid and then use computed properties within child components.

Create a validateContentNode to ensure the object has all necessary attributes, and use as a validator on the object in props
@marcellamaki marcellamaki mentioned this issue Oct 29, 2021
Merged
9 tasks
@MisRob
Copy link
Member

MisRob commented Nov 2, 2021

It might make sense to consider this issue in the broader context of #8533

@MisRob MisRob mentioned this issue Nov 2, 2021
Open
@marcellamaki marcellamaki mentioned this issue Nov 9, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcellamaki marcellamaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactors hybrid learning cards to use content object, not passed props marcellamaki/kolibri
2 participants
@MisRob @marcellamaki