Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive behaviors on setup wizard language switcher list no longer work as originally designed #7997

Closed
indirectlylit opened this issue Apr 12, 2021 · 7 comments
Assignees
Labels
bug Behavior is wrong or broken DEV: frontend help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: regression Something that previously worked

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Apr 12, 2021

Observed behavior

The number of visible languages is changing based on screen size breakpoints even though the available space is not changing.

This may have been an unintentional consequence of some unrelated layout changing, e.g. making the max-width of the setup wizard smaller.

2021-04-12 12 19 26

Expected behavior

UI layout should be responsive to actual available screen real estate.

User-facing consequences

Layout and text wrapping behavior on the very first screen users see behaves poorly.

Steps to reproduce

resize setup wizard window

Context

0.14.7 rc2
0.16.0b10

@indirectlylit indirectlylit added bug Behavior is wrong or broken DEV: frontend TAG: regression Something that previously worked labels Apr 12, 2021
@indirectlylit indirectlylit changed the title responsive behaviors on setup wizard language switcher list no longer work responsive behaviors on setup wizard language switcher list no longer work as originally designed Apr 12, 2021
@nucleogenesis nucleogenesis added P2 - normal Priority: Nice to have TODO: needs clarification Insufficient information to proceed and removed P2 - normal Priority: Nice to have labels Apr 13, 2021
@nucleogenesis nucleogenesis changed the title responsive behaviors on setup wizard language switcher list no longer work as originally designed Investigate: Responsive behaviors on setup wizard language switcher list no longer work as originally designed Apr 13, 2021
@rtibbles rtibbles added the TODO: needs QA re-review For stale issues that need to be revisited label Oct 13, 2023
@pcenov
Copy link
Member

pcenov commented Jan 5, 2024

@radinamatic this one is still valid in 0.16.0b10

@radinamatic radinamatic added TODO: needs decisions Design or specifications are necessary and removed TODO: needs QA re-review For stale issues that need to be revisited labels Jan 5, 2024
@rtibbles rtibbles changed the title Investigate: Responsive behaviors on setup wizard language switcher list no longer work as originally designed Responsive behaviors on setup wizard language switcher list no longer work as originally designed Jan 5, 2024
@rtibbles rtibbles added help wanted Open source contributors welcome and removed TODO: needs decisions Design or specifications are necessary TODO: needs clarification Insufficient information to proceed labels Jan 5, 2024
@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 1 milestone Jan 5, 2024
@FidalMathew
Copy link
Contributor

@rtibbles Can I work on this issue?

@AlexVelezLl
Copy link
Member

Hi @FidalMathew! Sure! I will assign this issue to you. Thank you!

@FidalMathew
Copy link
Contributor

test.mp4

@AlexVelezLl I think the setup_wizard page doesn't exist now. The language option is present on the auth/#/signin page. Can you confirm this? Let me know if any changes are required. Thank you!

@rtibbles
Copy link
Member

rtibbles commented Feb 6, 2024

@FidalMathew - the setup wizard still exists, however, you need to have a fresh KOLIBRI_HOME directory in order to see it, it is only used during initial setup.

You can see it again by running Kolibri with the KOLIBRI_HOME environment variable set to a new folder (if it doesn't exist, it will be created). When I do this, I tend to just use today's date as the folder name: KOLIBRI_HOME=~/.20240206 yarn run devserver-hot - this will run with a fresh folder, and should show you the setup wizard.

@FidalMathew
Copy link
Contributor

Thanks, @rtibbles got it!

@AlexVelezLl
Copy link
Member

Fixed in #11847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken DEV: frontend help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: regression Something that previously worked
Projects
None yet
Development

No branches or pull requests

7 participants