Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-provisioned devices are not redirected to Setup Wizard when going to /user/ routes #7020

Closed
jonboiser opened this issue Jun 10, 2020 · 4 comments · Fixed by #7024
Closed
Assignees
Labels
P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked
Milestone

Comments

@jonboiser
Copy link
Contributor

DeviceNotProvisioned at /en/user/
No exception message supplied

After starting the server with a new KOLIBRI_HOME I refreshed at /en/user and it did not redirect me to Setup Wizard as expected.

Originally posted by @nucleogenesis in #7010 (comment)

@jonboiser jonboiser added this to the 0.14.0 milestone Jun 10, 2020
@jonboiser jonboiser added TODO: needs clarification Insufficient information to proceed P0 - critical Priority: Release blocker or regression labels Jun 10, 2020
@jonboiser
Copy link
Contributor Author

@rtibbles My hunch is that this might be because of some changes to the redirect hooks in core/views.py?

@rtibbles rtibbles self-assigned this Jun 10, 2020
@rtibbles
Copy link
Member

My guess would be that parallel changes in develop are causing errors in the middleware - will debug.

@rtibbles
Copy link
Member

Oh... we deleted the middleware a while ago, and I think we were relying on root redirects to handle this, so I don't think this is new behaviour. It's just more egregious now, because the user page accesses device settings info in its plugin data, and gives this exception.

@rtibbles
Copy link
Member

OK, so the issue here is that we were previously doing the redirect in the frontend, but because the user page now tries to access a device setting during its data bootstrapping, it blocks the page from loading and so the redirect doesn't happen.

@jonboiser jonboiser removed the TODO: needs clarification Insufficient information to proceed label Jun 10, 2020
@indirectlylit indirectlylit added the TAG: regression Something that previously worked label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants