-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write-to-disk watch mode for kolibri tools to allow single origin dev testing. #4826
Comments
I just tried this out, and it still seems to be an issue for running the webpack devserver. However, the workaround we've been using is to just rebuild the app manually and run the django webserver, using these two steps
|
One other way around it would be to build in watch mode, but write to disk (but only in this circumstance). This would be a bit slower than the regular watch mode, but quicker than doing a full build each time. |
What's the command for running in watch mode? |
We'd have to expose an extra flag on the kolibri-tools build CLI to enable this I think, one that just writes the files to disk instead of using the webpack-dev-server. |
(webpack dev server is the more customisable version of webpack's watch mode) |
This should be implemented by adding a --write-to-disk flag to that only has an effect when running in When using this mode, it should also add a console.warning to tell the user that frequent changes in this mode may fill up their developer machine with lots of different built files. |
May i have this assigned? |
I have to run the |
Yes - hot reloading requires the webpack devserver, which this would not be using. I will assign you. |
Observed behavior
This appears to be due to a browserstack limitation: https://www.browserstack.com/question/758
As a workaround, http://kolibribeta.learningequality.org works fine
Browserstack reports:
We see:
Expected behavior
Kolibri should load
User-facing consequences
unable to use on iOS
Errors and logs
from Browserstack console:
Steps to reproduce
load kolibri on safari browserstack:
Note that you need to enter your local network IP address, not localhost on iOS. Or just use http://kolibribeta.learningequality.org
Context
#4589 looks related
k0.12
browserstack device info:
The text was updated successfully, but these errors were encountered: