Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kolibri start command can't detect if the port is not available. #4189

Closed
mrpau-richard opened this issue Aug 24, 2018 · 6 comments
Closed
Assignees
Labels
bug Behavior is wrong or broken P1 - important Priority: High impact on UX
Milestone

Comments

@mrpau-richard
Copy link
Contributor

Observed behavior

I have running KA LIte server on port 8008 then I run the kolibri start command at the command prompt and I used the same port 8008 then kolibri say it running on that port but when I check it it's not, still KA Lite using that port.

Expected behavior

kolibri start command should have an error that the port is not available.

Errors and logs

screen shot 2018-08-24 at 10 53 13 am

Context

Tell us about your environment, including:

  • Kolibri version: 0.10.1
  • Operating system: Windows 10
  • Browser
@mrpau-richard mrpau-richard changed the title kolibri start command can't detect if the port is available. kolibri start command can't detect if the port is not available. Aug 24, 2018
@benjaoming
Copy link
Contributor

This should be addressed in #3285

@benjaoming benjaoming added the P0 - critical Priority: Release blocker or regression label Aug 27, 2018
@benjaoming benjaoming added this to the 0.10.3 milestone Aug 27, 2018
@benjaoming benjaoming added the TODO: needs gherkin update Add to our manual integration tests label Aug 27, 2018
@indirectlylit indirectlylit removed this from the 0.10.3 milestone Aug 27, 2018
@indirectlylit indirectlylit removed the P0 - critical Priority: Release blocker or regression label Aug 27, 2018
@indirectlylit indirectlylit added this to the 0.11.0 milestone Aug 27, 2018
@indirectlylit indirectlylit added the P1 - important Priority: High impact on UX label Aug 27, 2018
@indirectlylit
Copy link
Contributor

also related and targeted to 0.11.0: #1707

@benjaoming
Copy link
Contributor

benjaoming commented Aug 27, 2018

@indirectlylit this was previously fixed in #3048, so the issue is a regression in 0.10 - not sure when, why etc :)

@indirectlylit indirectlylit added the bug Behavior is wrong or broken label Sep 24, 2018
@lyw07
Copy link
Contributor

lyw07 commented Sep 25, 2018

@mrpau-richard Hi! I'm wondering if you still have the kolibri.log file when this error happened. Thank you! My guess is that it detected the port was not available, but the error went to the log file, since the program checks the port availability right before the server starts.

@mrpau-richard
Copy link
Contributor Author

mrpau-richard commented Sep 26, 2018

@lyw07 your right, it did show in log file that the port is not available. But the logs appear only in the server.log not in the kolibri.log. I think, we should propagate those error logs at the command prompt or terminal to notify that the port is not available.

Here are my log files:
server.log
kolibri.log

@lyw07
Copy link
Contributor

lyw07 commented Sep 26, 2018

thank you! @mrpau-richard That makes sense to me. I will find ways to let the error show up at the terminal.

@lyw07 lyw07 mentioned this issue Sep 26, 2018
14 tasks
@radinamatic radinamatic removed the TODO: needs gherkin update Add to our manual integration tests label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

5 participants