Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate management page titles #2672

Closed
indirectlylit opened this issue Nov 22, 2017 · 1 comment
Closed

translate management page titles #2672

indirectlylit opened this issue Nov 22, 2017 · 1 comment
Labels
bug Behavior is wrong or broken TAG: user strings Application text that gets translated

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

currently, all pages that use preparePage pass in untranslated strings. For example:

  {
    name: PageNames.USER_PERMISSIONS_PAGE,
    path: '/permissions/:userid',
    handler: ({ params, name }) => {
      preparePage(store.dispatch, {
        name,
        title: 'Manage User Permissions',
      });
      showUserPermissionsPage(store, params.userid).then(hideLoadingScreen);
    },
  },

Expected behavior

page titles should be translated

User-facing consequences

some difficulty in other languages

Context

  • Kolibri version: 0.7
@indirectlylit indirectlylit added bug Behavior is wrong or broken TAG: user strings Application text that gets translated labels Nov 22, 2017
@jonboiser
Copy link
Contributor

This should have been fixed in #2610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken TAG: user strings Application text that gets translated
Projects
None yet
Development

No branches or pull requests

2 participants