Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move login/logout logic into the useUser composable and update references #12204

Open
1 task done
Tracked by #11722
rtibbles opened this issue May 23, 2024 · 4 comments · May be fixed by #12915
Open
1 task done
Tracked by #11722

Move login/logout logic into the useUser composable and update references #12204

rtibbles opened this issue May 23, 2024 · 4 comments · May be fixed by #12915
Assignees
@iamshobhraj
Labels
DEV: frontend help wanted Open source contributors welcome TAG: tech update / debt Change not visible to user
Milestone
Kolibri 0.19: Use...

Comments

@rtibbles
Copy link
Member

rtibbles commented May 23, 2024 •
edited
Loading

Prerequisites
Preview Give feedback
  1. Migrate all existing references to session getters and state to the useUser composable #12203
    DEV: frontend TAG: tech update / debt help wanted
    nathanaelg16

The login, logout, and session actions should be migrated into the useUser composable.

As this will have been done after the migration of all references to the getters and state to the useUser composable, the state should be removed from Vuex state and made into module level state in the useUser composable. The getters should be transferred to the useUser composable as computed refs based on the module level state.

Any references to the CORE_SET_SESSION mutation should also be updated: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/session.js#L89
@rtibbles rtibbles mentioned this issue May 23, 2024
Open
@rtibbles rtibbles added TAG: tech update / debt Change not visible to user DEV: frontend labels May 23, 2024
@rtibbles rtibbles added the help wanted Open source contributors welcome label Aug 28, 2024
@iamshobhraj
Copy link
Contributor

Hi @rtibbles , can i get this assigned?

@rtibbles
Copy link
Member Author

Yes, certainly! Please feel free to ask any questions about this, and also look at previous related PRs for guidance!

@iamshobhraj iamshobhraj linked a pull request Dec 6, 2024 that will close this issue
Open
@iamshobhraj
Copy link
Contributor

hi @rtibbles , i opened a pr for this issue. i moved the login/logout logic along with session logic in useUser composable but when i tried to update the CORE_SET_SESSION, some tests failed. I am unable to figure out why.

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

Hi @iamshobhraj, I wanted to mention that Learning Equality will be closed from December 23 to January 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamshobhraj iamshobhraj

Labels
DEV: frontend help wanted Open source contributors welcome TAG: tech update / debt Change not visible to user
Projects
None yet
Milestone
Kolibri 0.19: User Management
Development

Successfully merging a pull request may close this issue.

Moved login/logout logic into the useUser composable and updated references iamshobhraj/kolibri
4 participants
@rtibbles @MisRob @marcellamaki @iamshobhraj