Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top navigation - The username and the 'More options' button are not positioned correctly when shrinking the page #12813

Open
pcenov opened this issue Nov 11, 2024 · 6 comments
Assignees
Labels
bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Nov 11, 2024

Observed behavior

This is a follow-up to #12775 as the issue is present on develop:

The tabs in the navigation should go to the second line when there isn't enough space, and only after that we should be showing the ... button. See the video:

responsive.mp4

Steps to reproduce the issue

  1. Install the latest develop build
  2. Use a long facility name and username
  3. Go to Coach > Class home and start shrinking the page to see the responsive design behavior

Usage Details

Windows 11, Ubuntu 22 - Chrome

@pcenov
Copy link
Member Author

pcenov commented Nov 11, 2024

@radinamatic

@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression DEV: frontend labels Nov 11, 2024
@abhirupPann
Copy link

@radinamatic Can I work on it?

@LianaHarris360
Copy link
Member

Hi @abhirupPann, thanks for showing interest in fixing this issue! The issues open for contributors have a help wanted label, you can find some of those unassigned issues here.

@MisRob
Copy link
Member

MisRob commented Nov 12, 2024

Regarding the requirement

The tabs in the navigation should go to the second line when there isn't enough space, and only after that we should be showing the ... button

When I worked on tab-like components, I recall that two and more lines were rather discouraged because it's slightly confusing experience for both mouse and keyboard users. I wonder if it'd rather make sense to keep it always one line with ... button as now and rather decrease the space taken by the facility name?

@marcellamaki @radinamatic @jtamiace thoughts?

@radinamatic
Copy link
Member

Overflowing tabs in two lines may indeed be confusing, but the way I understood the reported issue and the recommendation was to (in cases like this) keep the facility name in the first line, and pass all the tabs together in the second line. This would at least make the need for ··· button to appear later, and only on the very narrow screens.

I think there is also a slight alignment issue of the ··· button: shouldn't it be left-aligned to the last visible tab? In the recording above it looks like right aligned to the username & icon... 🤔

@MisRob
Copy link
Member

MisRob commented Nov 12, 2024

the way I understood the reported issue and the recommendation was to (in cases like this) keep the facility name in the first line, and pass all the tabs together in the second line

Oh I see, I interpreted differently. Yes, this would makes most sense.

@LianaHarris360 LianaHarris360 self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

5 participants