-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure session and summary log outputs are consistent between channel and displayed node #12804
Conversation
Build Artifacts
|
25b270b
to
4e0a589
Compare
Hi @rtibbles - I noticed the following issues while manually testing:
Test channel token which you can use to replicate the issue: |
…content_id. Use node_id when available. Query for most recent session log to give parallel results for summary logs.
4e0a589
to
b5f51b4
Compare
Thanks @pcenov - I have fixed the first issue - I had originally left the second as intended behaviour because of the subtly different way we track data for summary logs vs session logs, but I am inspecting the session logs to get the data we need to ensure consistent behaviour between the two now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rtibbles - I confirm that the above mentioned issues are fixed now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense! I have tested the PR locally and logs are consistent!
Summary
References
Fixes #12791
Reviewer guidance
Engage with resources that are in multiple channels (e.g. some KA exercises for different languages, and those that have been copied into the Kolibri QA channel).
Export the session and summary logs.
Make sure that the topic tree hierarchy and the channel name match up to each other in the logs.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)