You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've recently updated KDS to account for some theme token incompatibilities when theming our custom installers. We want to upgrade this in 0.17.x and replace any of the now-outdated tokens in Kolibri. This will allow us to upgrade any of our installers with custom theme colors without issue moving forward.
KDS is upgrade to v4.6.0. There should not be other breaking changes that need to be updated/addressed in Kolibri as part of this dependency upgrade, but please read the release notes
any places that use the theme token numerical values in kolibri (so, anything that aligns with the updates spec in Update KDS Theme Token values kolibri-design-system#775) should be updated to use the correct value. So, themeTokens.primary does not need to be updated anywhere. But, if there is a place where themeTokens.v_1000 is used, that needs to be updated to themeTokens.v_500. Note: I have not proactively evaluated how many places will need to be updated. It may be a handful, it may be a lot!
No regressions in the UI in terms of colors, or console errors. Please tag the QA team for review.
Once all of the code updates are made, message Marcella for help QAing with a custom theme kolibri plugin.
The text was updated successfully, but these errors were encountered:
Overview
We've recently updated KDS to account for some theme token incompatibilities when theming our custom installers. We want to upgrade this in 0.17.x and replace any of the now-outdated tokens in Kolibri. This will allow us to upgrade any of our installers with custom theme colors without issue moving forward.
Get familiar with the context by reading:
https://learningequality.slack.com/archives/C0LKG14NL/p1721142804904449
learningequality/kolibri-design-system#775
learningequality/kolibri-design-system#782
https://learningequality.slack.com/archives/C0LE9NLCE/p1727812826832089
https://www.notion.so/learningequality/2024-09-17-KDS-Tactical-104f45d6ef9680be8cfada205c91efea?pvs=4#b80634a3dc4c4ad6b6077e4ba0bf9c8e
Acceptance criteria
themeTokens.primary
does not need to be updated anywhere. But, if there is a place wherethemeTokens.v_1000
is used, that needs to be updated tothemeTokens.v_500
. Note: I have not proactively evaluated how many places will need to be updated. It may be a handful, it may be a lot!The text was updated successfully, but these errors were encountered: