Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useLanguage broken after move to kolibri-common #12720

Closed
nucleogenesis opened this issue Oct 15, 2024 · 0 comments · Fixed by #12745
Closed

useLanguage broken after move to kolibri-common #12720

nucleogenesis opened this issue Oct 15, 2024 · 0 comments · Fixed by #12745
Assignees
Labels
P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked

Comments

@nucleogenesis
Copy link
Member

Observed behavior

The useLanguages module relies on the plugin_data module, but in the kolibri-common context, the languages property is not set, so useLanguages is retruning empty values.

Note that useLanguages is only really used in the useBaseSearch module and SearchChips.

Perhaps SearchChips should also be moved into the useBaseSearch module folder in kolibri-common?

Errors and logs

Expected behavior

useLanguages should return a map and array of available languages

User-facing consequences

Currently, SearchChips relies on useLangauges to get the label value for a language (ie, using languageMap like languageMap['en']; // => "English".

Steps to reproduce

Filter a search by Language on the Learn > Library page.

Context

0.18 / develop branch

@nucleogenesis nucleogenesis added P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked labels Oct 15, 2024
@rtibbles rtibbles assigned rtibbles and nucleogenesis and unassigned rtibbles Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants