Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and replace unwrapped "up" and "down" strings used for aria labeling #12392

Closed
marcellamaki opened this issue Jul 2, 2024 · 1 comment
Assignees
Labels
P0 - critical Priority: Release blocker or regression TAG: a11y Affecting accessibility TAG: user strings Application text that gets translated TODO: needs decisions Design or specifications are necessary

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Jul 2, 2024

Observed behavior

There are some places where the strings that are passed to draggable items, for aria labels, are regular strings (i.e. "up" "down" and are not translated strings). We may want to consider using a commonCoreString translation for these? and translating and replacing all with 0.18. There might also be a case for not using a common string.

User-facing consequences

Non-translated aria labels

To Dos

  • Audit all "up" "down" or other ariaLabel strings that are untranslated and share a list in #kolibri-dev tagging @marcellamaki and @radinamatic
  • After follow up decision about whether or not we should create commonCore strings for the existing use cases, update all relevant strings with their proper translated reference.
@marcellamaki marcellamaki changed the title Audit and replace unwrapped Audit and replace unwrapped "up" and "down" strings used for aria labeling Jul 2, 2024
@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression TODO: needs decisions Design or specifications are necessary TAG: a11y Affecting accessibility labels Jul 2, 2024
@marcellamaki marcellamaki added the TAG: user strings Application text that gets translated label Oct 8, 2024
@AllanOXDi AllanOXDi self-assigned this Nov 1, 2024
@AllanOXDi
Copy link
Member

fixed in #12817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression TAG: a11y Affecting accessibility TAG: user strings Application text that gets translated TODO: needs decisions Design or specifications are necessary
Projects
None yet
Development

No branches or pull requests

2 participants