-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQM: Only show save success message when saving #12389
EQM: Only show save success message when saving #12389
Conversation
Build Artifacts
|
Hi @nucleogenesis here are the issues I was able to identify after this change:
2024-07-02_15-23-36.mp4
adding.questions.mp4
save.mp4
delete.the.only.available.section.mp4 |
Thanks @pcenov ! For (1) and (2), this was discussed a bit on Slack today and @marcellamaki noted that now, where there are no snackbars as you noted there, the user does see a sort of "confirmation" in that the side panel closes. This should happen for all cases. We'll gather some feedback from the team around this area. For (3) I actually fixed it last night in a different body of work, but didn't include it because I wanted to be sure it wasn't a bug already reported. It has not been reported elsewhere, so I've committed here. For (4) the best solution I could come up with here to mitigate the issue is to make the larger error box dismissible. I initially was going to make it so that typing into the title box dismisses the larger error box, but that might not be desirable in some cases. In this case, however, the user can dismiss it so I hope this is a suitable UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making these last handful of adjustments, @nucleogenesis!
Summary
Only shows the "Changes saved successfully" message when actually saving the quiz.
There are now no longer any snackbars when the user does a few things, like selecting resources or applying their new section settings, perhaps we'll want to improve on this in the next iteration.
References
Fixes #12333
Reviewer guidance
Try to save and to save & close both in the "Select quiz" and throughout the quiz creation flow - you should only see a "Changes saved successfully" message when you've saved the quiz successfully.