EQM: Section form validation improvements #12262
Labels
P0 - critical
Priority: Release blocker or regression
TAG: user strings
Application text that gets translated
Milestone
Overview
Follow-up to comments here.
Overall, this issue is to address the issues reported by Peter. The changes in that PR which introduced these issues are in this commit
At a high level, we need to be sure that the form's validation flags are being set appropriately as things happen. It feels to me like there are a lot more moving parts than should be necessary, but refactoring the whole thing proprly be more work than it's worth at this point, so some key things to consider:
KTextbox
props -showInvalidText
is a sort of override saying "show errors no matter what when true", whereasinvalidText
is the text andinvalid
is just tellingKTextbox
"this is invalid, do with it what you will" (I'm sorry... I added that prop but now I regret it lolThe error messages should show when the user needs to know it -- for example, when they're currently typing into the title box, if their title is a dupe, we show the error, but if they're not focusing it, then we hide it -- but if they click to submit, we focus the title and show the error.
Cannot make sections with duplicate titles
Improved validations UX (consider reaching out in #kolibri-dev for guidance if you have questions about the best UX for a particular item)
The text was updated successfully, but these errors were encountered: