Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords search placeholder text cut off at narrow sizes #12238

Open
dylanmccall opened this issue Jun 4, 2024 · 3 comments
Open

Keywords search placeholder text cut off at narrow sizes #12238

dylanmccall opened this issue Jun 4, 2024 · 3 comments

Comments

@dylanmccall
Copy link
Contributor

Observed behavior

When the viewport is between and 840 and 1264 pixels, Kolibri's left sidebar is made narrower, which includes the Keywords search input (.search-box-row .search-input). This input field has placeholder text saying "Find something to learn".

At the narrower size, the placeholder text is cut off. On my device, it displays "Find someth". The problem is exacerbated by another element (.search-box-row .search-buttons-wrapper) causing the available space for the actual input field to be quite small despite the reserved space being empty.

Screen Shot 2024-06-04 at 10 42 47

Expected behavior

Instead, either this placeholder text should be replaced with a shorter string at this breakpoint, or it should be removed altogether. (One convention is to place a small label below the input field with the same text).

In addition, the appearance of .search-clear-button could be conditional on whether the placeholder text is displayed.

User-facing consequences

The result of this is Kolibri's Library page looks kind of incomplete with a wide range of viewport sizes.

Context

@kartik-212004
Copy link

I'm interested in working on this issue and would appreciate being assigned to it.

@MisRob
Copy link
Member

MisRob commented Dec 2, 2024

Hi @kartik-212004, thank you for volunteering. Let me confirm first with our designers what exactly we want to see as the expected behavior. I will get back to you.

@MisRob
Copy link
Member

MisRob commented Dec 4, 2024

Hi @kartik-212004, so here we'd like to achieve the following behavior:

  • In all cases, truncate "Find something to learn" with ellipsis ...
  • Further improve experience by changing "Find something to learn" string to only "Find" on all smaller breakpoints where "Find something to learn" is not visible in its entirety (truncation described above serves rather as fallback to this behavior because we may not be able to estimate precisely)

You would need to add a new string "Find". See https://kolibri-dev.readthedocs.io/en/develop/i18n.html.

Let me know if we should assign you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants