Pre-commit hooks not looking out for print statements #11990
Labels
DEV: tools
Internal tooling for development
P2 - normal
Priority: Nice to have
TAG: tech update / debt
Change not visible to user
Milestone
Observed behavior
Reference: #11978 (comment)
Currently the precommit hooks are not detecting print statements in our code base, and there are many of them that have made into our codebase.
Expected behavior
noqa
comments) are there in the code.(Introduce flake8-print)logger
ornoqa
comments should be added to themUser-facing consequences
Developers using print statements for testing and debugging miss out some print statements while commiting. So the pre-commit will stop them from doing so.
Steps to reproduce
Run the pre-commit on all files, you can see everything pass, but there are many print statements throughout codebase
https://github.com/learningequality/kolibri/blob/develop/kolibri/core/auth/management/utils.py#L52
Context
Observed on develop but same for elsewhere
The text was updated successfully, but these errors were encountered: