-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "insufficient storage" conditon #11774
Comments
@marcellamaki can I work on this issue? |
@marcellamaki Please Assign me this issue. I would love to work on this |
Thanks @FidalMathew and @shivansh-bhatnagar18 for volunteering. It seems @iskipu already has a PR for that. Thanks @iskipu, and also would you mind asking for an assignment before working on something next time? Please have a look at contributing guidelines. It will always take us some time to respond to all comments we're receiving on issues, and it'd help us to distribute work. |
I am so sorry i started working on this and i havent noticed that people already requested for an assignment which caused the problem sorry @FidalMathew & @shivansh-bhatnagar18 i will make sure i ask for an assignment before working. |
No problem @iskipu, thank you for your understanding. |
@marcellamaki Please assign this task to me if it is still open |
Hi @Yogeshlodhi, thank you for volunteering, this is already being addressed in #11809 |
Fixed in #11809 |
The banner that displays on a LOD when a user sync status is "Insufficient Storage" should only appear on Learn. Currently, it displaying also in the Device plugin, as seen below.
Because the StorageNotificationBanner is widely used and exists incore
, this should not be moved (i.e. moving the component itself only to Learn), but rather, the condition should be updated.(After further discussion, updated)
We should remove the banner from the AppBarPage, and instead put it into the relevant place in the Learn page
The banner:
INSUFFICIENT_STORAGE
INSUFFICIENT_STORAGE
while they are in the Device Plugin(While not a release blocker, this is an important change that we are prioritizing. This is open for community contribution, but contributors interested in this issue should only volunteer if they will be available to work on it promptly.)
The text was updated successfully, but these errors were encountered: