Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "insufficient storage" conditon #11774

Closed
3 tasks
marcellamaki opened this issue Jan 23, 2024 — with Slack · 8 comments
Closed
3 tasks

Update "insufficient storage" conditon #11774

marcellamaki opened this issue Jan 23, 2024 — with Slack · 8 comments
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend help wanted Open source contributors welcome P1 - important Priority: High impact on UX

Comments

Copy link
Member

marcellamaki commented Jan 23, 2024

The banner that displays on a LOD when a user sync status is "Insufficient Storage" should only appear on Learn. Currently, it displaying also in the Device plugin, as seen below.

image

Because the StorageNotificationBanner is widely used and exists in core, this should not be moved (i.e. moving the component itself only to Learn), but rather, the condition should be updated.
(After further discussion, updated)
We should remove the banner from the AppBarPage, and instead put it into the relevant place in the Learn page

The banner:

  • should appear in Learn when the status is INSUFFICIENT_STORAGE
  • should be dismissed after a user clicks "manage channels" and is redirected
  • the banner should not ever appear in the Device plugin, even if the user's status changes to INSUFFICIENT_STORAGE while they are in the Device Plugin

(While not a release blocker, this is an important change that we are prioritizing. This is open for community contribution, but contributors interested in this issue should only volunteer if they will be available to work on it promptly.)

@marcellamaki marcellamaki added the P1 - important Priority: High impact on UX label Jan 23, 2024 — with Slack
@marcellamaki marcellamaki added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend help wanted Open source contributors welcome labels Jan 23, 2024
@FidalMathew
Copy link
Contributor

@marcellamaki can I work on this issue?

@shivansh-bhatnagar18
Copy link

@marcellamaki Please Assign me this issue. I would love to work on this

@MisRob
Copy link
Member

MisRob commented Jan 30, 2024

Thanks @FidalMathew and @shivansh-bhatnagar18 for volunteering. It seems @iskipu already has a PR for that. Thanks @iskipu, and also would you mind asking for an assignment before working on something next time? Please have a look at contributing guidelines. It will always take us some time to respond to all comments we're receiving on issues, and it'd help us to distribute work.

@iskipu
Copy link
Contributor

iskipu commented Jan 31, 2024

Thanks @iskipu, and also would you mind asking for an assignment before working on something next time?

I am so sorry i started working on this and i havent noticed that people already requested for an assignment which caused the problem sorry @FidalMathew & @shivansh-bhatnagar18 i will make sure i ask for an assignment before working.

@MisRob
Copy link
Member

MisRob commented Jan 31, 2024

No problem @iskipu, thank you for your understanding.

@Yogeshlodhi
Copy link

@marcellamaki Please assign this task to me if it is still open

@MisRob
Copy link
Member

MisRob commented Feb 12, 2024

Hi @Yogeshlodhi, thank you for volunteering, this is already being addressed in #11809

@marcellamaki
Copy link
Member Author

Fixed in #11809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend help wanted Open source contributors welcome P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

6 participants